Rename cor into correlation_matrix
#1113
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @strengejacke, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing code clarity and consistency within the statistical functions by renaming the cor parameter to the more descriptive correlation_matrix. This change is applied across function definitions, internal logic, and user-facing documentation, making the parameter's purpose more explicit.
Highlights
- Parameter Renaming: The
corparameter has been consistently renamed tocorrelation_matrixacross thefactor_analysis,n_factors, andn_componentsfunctions, as well as their internal helper functions and calls. - Codebase Updates: All internal logic, conditional checks, and function calls that previously utilized the
corparameter have been updated to correctly referencecorrelation_matrix. - Documentation Alignment: The Roxygen documentation files (
.Rd) forn_factorsandprincipal_componentshave been updated to reflect the newcorrelation_matrixparameter name and its detailed description, ensuring consistency for users.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request successfully renames the cor argument to correlation_matrix in n_factors and refactors factor_analysis to avoid argument collisions, enhancing flexibility by allowing direct argument passing to psych::fa. It also introduces valuable improvements to display and print methods, particularly for PCA/EFA objects, by refactoring for better maintainability and adding new HTML output capabilities. Documentation and tests are well-updated to reflect these changes. Overall, the changes are robust and improve the codebase. Several low to medium severity issues were identified, mostly related to maintainability and consistency.
| insight::format_error( | ||
| "Please input the correlation matrix via the `cor` argument and the number of rows / observations via the first argument." # nolint | ||
| "Please input the correlation matrix via the `correlation_matrix` argument and the number of rows / observations via the first argument." # nolint | ||
| ) |
There was a problem hiding this comment.
This error message is now referring to correlation_matrix instead of cor. Consider updating the message to reflect this change.
"Please input the correlation matrix via the `correlation_matrix` argument and the number of rows / observations via the first argument." # nolint
See easystats/performance#793 (comment)